Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #287

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Update README #287

merged 1 commit into from
Sep 9, 2020

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Sep 9, 2020

Purpose

Update README.

What is the code doing?

There is no code

Where to look

In section 2 where we list the attributes of the Grid class. the type2color, type2id and id2type dictionaries have been moved in the powersimdata.network.usa_tamu.constants.plants module

Time estimate

15 sec

@rouille rouille added the documentation Documentation related to package label Sep 9, 2020
@rouille rouille added this to the Movin' Out milestone Sep 9, 2020
@danielolsen
Copy link
Contributor

danielolsen commented Sep 9, 2020

Can we get rid of id2type and type2id entirely? As far as I can tell they are only used once, in PostREISE, as a list of which resources are present in a grid. If that is truly the case, these dictionaries add no new information and should be refactored out.

See: https://github.com/Breakthrough-Energy/PostREISE/search?q=id2type&unscoped_q=id2type

@rouille
Copy link
Collaborator Author

rouille commented Sep 9, 2020

Can we get rid of id2type and type2id entirely? As far as I can tell they are only used once, in PostREISE, as a list of which resources are present in a grid. If that is truly the case, these dictionaries add no new information and should be refactored out.

See: https://github.com/Breakthrough-Energy/PostREISE/search?q=id2type&unscoped_q=id2type

This can be done once we are done refactoring the plots in PostREISE.. I don't want to touch the AnalyzePG now knowing that it is going to disappear in the coming weeks.

@rouille rouille merged commit 38ca9da into develop Sep 9, 2020
@rouille rouille deleted the ben/readme branch September 9, 2020 21:30
@ahurli ahurli mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related to package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants