fix: update paramiko and create local directory if needed #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenhagg
force-pushed
the
jon/local-cache
branch
from
e9f2f9e to
a57404f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #272
What it does
Create
~/ScenarioDatafolder if it doesn't exist yet. Raises exception rather than returnNoneif the local file doesn't exist (this shouldn't happen, but just handling that code path).Also needed to update paramiko since updating to
cryptography==3.1apparently has a bug (see paramiko/paramiko#1723).Time to review
5 mins. Loaded a scenario locally after the changes and it worked as expected.