Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append new branches to branch data frame of Grid object #177

Merged
merged 1 commit into from
May 14, 2020

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented May 13, 2020

Purpose

Fix bug when adding AC lines through change table (issue #176).

What is the code doing?

It appends the data frame enclosing the new branches to the existing one.

Where to look

in powersimdata/input/scaler.py, a single line of code is added

Ime estimate

2min

@rouille rouille added the bug Something isn't working label May 13, 2020
@rouille rouille added this to the Glorious Sun milestone May 13, 2020
@rouille rouille requested a review from danielolsen May 13, 2020 23:43
@danielolsen
Copy link
Contributor

Do we have the same issue for DC lines?

@rouille
Copy link
Collaborator Author

rouille commented May 13, 2020

No we don't, the appending is there.

@rouille rouille merged commit 36688f4 into develop May 14, 2020
@rouille rouille deleted the fix_add_acline branch June 15, 2020 18:47
@ahurli ahurli mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants