Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: populate optional area_type to all related functions #170

Merged
merged 1 commit into from
May 8, 2020

Conversation

BainanXia
Copy link
Collaborator

Purpose

The area_type parameter is added to function area_to_loadzone, however, it is not populated to the functions that call area_to_loadzone.

What is the code doing

populate optional area_type to all related functions.

Validation

All tests still passed.

Time to review

5mins

@BainanXia BainanXia added the bug Something isn't working label May 7, 2020
@BainanXia BainanXia added this to the Spring Board milestone May 7, 2020
@BainanXia BainanXia requested a review from dmuldrew May 7, 2020 23:56
@BainanXia BainanXia requested a review from rouille May 8, 2020 16:35
Copy link
Collaborator

@dmuldrew dmuldrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made one these changes with the get_capacity function when working on change table output, but then realized I couldn’t use the functionality with the current mixing of states and load zone names in the current target spreadsheet.

@BainanXia BainanXia merged commit a809f11 into develop May 8, 2020
@BainanXia BainanXia deleted the populate_area_type_in_sceanrio_info branch May 8, 2020 19:56
@ahurli ahurli mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants