Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: revert Pmax changes to hydro, update branch instead #167

Merged
merged 1 commit into from
May 6, 2020

Conversation

danielolsen
Copy link
Contributor

Purpose

Revert to old Pmax values for hydro, so that our current scenario-run process maintains the previous profile scaling. Undoes #162.

What is the code doing

In plant.csv, revert all changes.

In branch.csv, upgrade the capacity of one line which had been causing problems for hydro fixed exactly to profiles (REISE.jl), but not hydro fixed within 0.1 MW of profiles (REISE).

Time to review

Five to ten minutes. You can verify that plant.csv is identical to before, and that the one changed branch is 3x its previous rateA (and 1/3 its previous r and x).

@BainanXia
Copy link
Collaborator

I was comparing the plant.csv here with the one currently in my local branch generation_update_westerntexas_2020 and found dimensionality is different, here vs ref = 13935 vs 14050. I presume that's because of the offshore wind. Question: how this revert works, will it revert the changes we made at that time point and apply it also at that time point without cause issues for future commits?

@danielolsen
Copy link
Contributor Author

generation_update_westerntexas_2020 has plants that are not yet merged into develop, so the dimension mismatch is to be expected I think.

I believe that since I created this PR in the standard way, not the official git 'revert' process, it should not create any additional issues.

@BainanXia
Copy link
Collaborator

BainanXia commented May 6, 2020

Confirmed.

>>> all(plant == plant_ref.iloc[:13935])
True

Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clean. Thanks.

@danielolsen danielolsen merged commit 5b1039c into develop May 6, 2020
@danielolsen danielolsen deleted the revert_hydro_pmax_changes branch May 6, 2020 22:24
@ahurli ahurli mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants