fix: when scaling gen Pmax, also scale Pmin and cost curve #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
mentioned this pull request
|
@danielolsenIV we need to discuss this change in person. This afternoon? |
|
Scaling cost coefficients has been fixed to be in the right place. I also added a couple of lines to avoid a potential divide-by-zero error (for example, if we want to shut down all coal plants in Washington state). |
kasparm
force-pushed
the
gen_scaling_improvement
branch
from
e10544a to
557ea2f
Compare
kasparm
force-pushed
the
gen_scaling_improvement
branch
from
557ea2f to
b1f8970
Compare
kasparm
approved these changes
Aug 5, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for scaling thermal generation properly. Since we are scaling up and down capacity of existing units rather than adding/subtracting units, we should also be scaling other parameters besides P_max so that the overall generator profile is consistent. I.e. when scaling, P_min:P_max ratio remains the same, marginal cost at P_min is the same, and marginal cost at P_max is the same.