Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to set simulation engine when creating a scenario #141

Merged
merged 4 commits into from
Apr 15, 2020

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Apr 10, 2020

Purpose

Add a feature allowing the user to set the simulation engine when creating a scenario. See issue #139 where most of the steps needed to implement this feature have been tested.

What is the code doing?

  • add the engine key to the _scenario_info attribute (type: dict) of the Create object.
  • add the engine attribute to the _Builder object with REISE (type: str) as default value.
  • update the update_scenario_info method in the Create object.
  • write the set_engine method in the _Builder object (limited to only REISE for now).
  • use scripts call.py and extract_data.py associated to engine set by user in the Execute object.
    The engine will be written in a new column right after the interval column.

Where to look

Two modules have been modied:

  • powersimdata.scenario.create
  • powersimdata.scenario.execute

Time estimate

30 minutes

Note

This PR can only be merged once a new column has been added to the ScenarioList.csv for the existing scenarios. Also, a companion PR that takes care of the insertion of the runtime and infesibilities in ScenarioList.csv handled, respectively, by the call.py and extract_data.py scripts will be created in REISE.

@rouille rouille added the new feature Feature that is currently in progress. label Apr 10, 2020
@rouille rouille added this to the Cherry Blossom milestone Apr 10, 2020
@rouille rouille merged commit 79349dc into develop Apr 15, 2020
@rouille rouille deleted the add_step_engine branch April 15, 2020 21:29
@ahurli ahurli mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Feature that is currently in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants