Add step to set simulation engine when creating a scenario #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a feature allowing the user to set the simulation engine when creating a scenario. See issue #139 where most of the steps needed to implement this feature have been tested.
What is the code doing?
engine
key to the_scenario_info
attribute (type:dict
) of theCreate
object.engine
attribute to the_Builder
object withREISE
(type:str
) as default value.update_scenario_info
method in theCreate
object.set_engine
method in the_Builder
object (limited to only REISE for now).call.py
andextract_data.py
associated to engine set by user in theExecute
object.The engine will be written in a new column right after the interval column.
Where to look
Two modules have been modied:
powersimdata.scenario.create
powersimdata.scenario.execute
Time estimate
30 minutes
Note
This PR can only be merged once a new column has been added to the ScenarioList.csv for the existing scenarios. Also, a companion PR that takes care of the insertion of the runtime and infesibilities in ScenarioList.csv handled, respectively, by the
call.py
andextract_data.py
scripts will be created in REISE.