Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use call and extract_data modules from REISE #134

Merged
merged 3 commits into from
Apr 9, 2020

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Apr 5, 2020

Purpose

Change path to the call and extract_data module in the launch_simulation and extract_simulation_output methods of the Execute object to reflect their new location.

This PR needs to be merged after PR 59 in REISE is merged and checked out on the server.

What is the code doing?

Use the call and extract_data modules in REISE.

Time estimate

Very quick. 10 minutes.

@rouille rouille added the new feature Feature that is currently in progress. label Apr 5, 2020
@rouille rouille added this to the Cherry Blossom milestone Apr 5, 2020
@rouille rouille requested review from danielolsen and kasparm April 5, 2020 23:33
@rouille rouille force-pushed the call_and_extract_from_REISE branch 3 times, most recently from 244c95a to cf19a3f Compare April 7, 2020 17:55
Copy link
Contributor

@kasparm kasparm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works fine.
Nice work.

@rouille rouille force-pushed the call_and_extract_from_REISE branch from cf19a3f to 1150778 Compare April 9, 2020 04:05
@rouille rouille merged commit fa398ce into develop Apr 9, 2020
@rouille rouille deleted the call_and_extract_from_REISE branch April 9, 2020 04:13
@ahurli ahurli mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Feature that is currently in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants