fix: avoid error when scaling from scenario with slightly negative generation #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Avoid an
AssertionError
when callingAbstractStrategyManager.populate_targets_with_resources()
using aScenarioInfo
object based on aScenario
whereprev_generation
for a state/gentype evaluates to a slightly negative number. This can be seen when trying this on Scenario 409.What is the code doing
Adding a small tolerance range to the negativity check in
set_generation()
, where if the value being passed is negative but within this tolerance, it is set to 0. Also adding more description to the error message on the assert.Time to review
Extremely short, it's 5 lines of changes. It can be tested using Scenario 409: it should fail using develop but pass using this branch.