-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move modules #126
Move modules #126
Conversation
There's another PowerSimData PR which moves files around, is there going to be conflict here? |
It does not really matter. These PRs are independent. That said the one who goes second will have to rebase before merging into develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works fine. Some dependencies still exist:
- PostREISE
./powersimdata/input/design_transmission.py:from postreise.analyze.transmission.distance import haversine
./powersimdata/scenario/execute.py: '/home/EGM/v2/PostREISE/postreise/extract/extract_data.py',
./powersimdata/scenario/tests/test_scenario_info.py:from postreise.tests.mock_scenario import MockScenario
- PreREISE
/powersimdata/scenario/scenario_info.py:from prereise.gather.constants import abv2state, state2loadzone,
We will fix those dependencies in the next sprint. |
Purpose
In order to integrate the REISE.jl engine to the scenario framework, we need to move some modules across packages as shown in the image below.

This PR concerns only the PowerSimData package. The
const
andtransferdata
modules have been moved from the PostREISE package to a new folder powersimdata/utility/ in the PowerSimData package. Additional PRs will follow to achieve the reorganization shown on the above image.The PowerSimData package can now be used with no reference to PostREISE.
See issue #250 in the RenewableEnergyProject repository for additional details.
An interactive rebase will be done to keep only the most relevant commit messages after all the comments are addressed.
What is the code doing
There is no new code. Modules have been moved from the PostREISE package to the PowerSimData package. Tests have been written for the
transfer_data
module.Where to look
The powersimdata/utility/ folder.
Time estimate
Hald an hour.
Note
Tests passed:
Also, the LMP data frame for scenario 87 has been successfully downloaded from the server after moving the
transfer_data
module in PowerSimData: