feat: adds Resource Manager to integrate existing notebook code #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the commit history is clean and meaningful, which satisfies the requirement. Any other concerns from your side @kasparm ? |
kasparm
reviewed
Mar 20, 2020
feat: updated demo notebook for Eastern Capacity scaling feat: integration of notebook code into TargetManager and AbstractStrategy objects
dmuldrew
force-pushed
the
capacity_planning_rebased
branch
from
639af95 to
9170882
Compare
kasparm
approved these changes
Mar 24, 2020
BainanXia
approved these changes
Mar 24, 2020
dmuldrew
force-pushed
the
capacity_planning_rebased
branch
from
1d262e9 to
a7af055
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one new class:
ResourceManagerand two new functions:
populate_targets_with_resources(self, scenario_info, start_time, end_time)def populate_resource_info(self, scenario_info,start_time, end_time)along with corresponding updates to the demo notebooks and overall documentation improvement.
Last, a requirements fix to eliminate potential future
Paramikocryptography dependency bugs.