Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add info attribute to ScenarioInfo class #113

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

BainanXia
Copy link
Collaborator

@BainanXia BainanXia commented Mar 12, 2020

Purpose

Now, the user could query scenario info from a ScenarioInfo instance as they do for scenario object.

ScenarioInfo(scenario).info = scenario.info

What is the code doing

Add a new attribute 'info' into ScenarioInfo object

Where to look

scenario_info.py

Time Estimate

One line commit. It should be fast.

Now, the user could query scenario info from a ScenarioInfo instance as they do for scenario object.
@BainanXia BainanXia added this to the Suncadia Break milestone Mar 12, 2020
@BainanXia BainanXia requested a review from dmuldrew March 12, 2020 21:52
Copy link
Collaborator

@dmuldrew dmuldrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@BainanXia BainanXia merged commit 0d115fd into develop Mar 13, 2020
@BainanXia BainanXia deleted the add_info_field_to_scenario_info branch March 13, 2020 17:42
@ahurli ahurli mentioned this pull request Mar 11, 2021
@rouille rouille changed the title feat: add_'info'_field_to_scenario_info_object feat: add info attribute to ScenarioInfo class Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants