Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capacity planning resource manager #109

Merged
merged 13 commits into from
Mar 18, 2020
Merged

Capacity planning resource manager #109

merged 13 commits into from
Mar 18, 2020

Conversation

dmuldrew
Copy link
Collaborator

@dmuldrew dmuldrew commented Mar 7, 2020

Adds ResourceManager class to handle importing resource information from ScenarioInfo object.

@dmuldrew dmuldrew requested a review from BainanXia March 7, 2020 07:56
@BainanXia
Copy link
Collaborator

Thanks for the refactor, according to the latest demo in EasternCapacityScaling.ipynb, the overhead of using the framework is largely reduced, which I think is good enough for now. A few questions I would like to discuss at this point:

  1. Are we using capacity_planning_demo.ipynb any more? If not, should we remove it from the repo.
  2. This PR is to reduce the user's overhead so that the steps of generating the target capacities for next scenario are shortened and clean. Should we address the package/folder restructure issue in this PR as well, i.e. create a design folder, put design_transmission and this framework into it and appropriately rename the folder, such as scaling, etc. @rouille
  3. How about the test folder restructure, i.e. put all data files into a data folder.

@dmuldrew
Copy link
Collaborator Author

dmuldrew commented Mar 16, 2020 •
edited
Loading

I'd save moving files around for a followup PR... Making code changes and moving files in a single PR just makes things more confusing, as we learned with the Eastern Demand PRs.

@dmuldrew
Copy link
Collaborator Author

After this PR gets in, folder restructuring, we might think about incorporating direct change table output...

@BainanXia
Copy link
Collaborator

After this PR gets in, folder restructuring, we might think about incorporating direct change table output...

Sure. Let discuss this probably in the follow up PR. I'll run an integration test via the demo notebook this afternoon to check whether the outputs match previous one. If it looks good, I'll approve this PR.

@dmuldrew dmuldrew force-pushed the capacity_planning_resource_manager branch from 489f52b to d6f677b Compare March 17, 2020 22:24
BainanXia
BainanXia approved these changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice!
The integration tests for the current version are passed, check details at
Dropbox (IVL)/Explorations/BainanX/capacity planning framework tests/EasternCapacityScaling.ipynb

@dmuldrew dmuldrew merged commit 556cd30 into develop Mar 18, 2020
@dmuldrew dmuldrew deleted the capacity_planning_resource_manager branch April 4, 2020 01:01
@ahurli ahurli mentioned this pull request Mar 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouille rouille rouille left review comments

@BainanXia BainanXia BainanXia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmuldrew @BainanXia @rouille