Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete correct scenario in ExecuteList file #108

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Mar 4, 2020

Purpose

Fix a bug when deleting a scenario

What is the code doing

It fixes the sed command used to to delete an entry in the ExecuteList.csv file.

Where to look

It is a one line change.

Time estimate

Very quick.

@rouille rouille added the bug Something isn't working label Mar 4, 2020
@rouille rouille requested review from danielolsen and kasparm March 4, 2020 17:56
@danielolsen
Copy link
Contributor

Tested by deleting Scenario 39, and it didn't delete Scenarios 394, 395, or 396.

Copy link
Contributor

@danielolsen danielolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't vouch for the sed command, but it's tested and fixes the bug that we had been seeing.

@rouille rouille merged commit 416cd0b into develop Mar 4, 2020
@rouille rouille deleted the delete_execute_bug branch March 4, 2020 18:49
@ahurli ahurli mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants