-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify Grid Model in Scenario List #84
Comments
Related: we currently have some stuff in |
One of the things that @rouille and I discussed last week: where should we record the grid model that was used to build a particular scenario? The options we discussed were either as another column in the ScenarioList.csv file (or database equivalent) vs. a field in the case.mat/grid.mat file. I think it comes up when we want to be able to automatically instantiate a 'base' grid to compare against (previously we would call There are probably many other places in the codebase that will be touched by this change. |
@danielolsen Probably we will need both. Since the model a scenario used is a key fundamental parameter, we definitely need this info in the |
@BainanXia if we have this in the |
I like the idea of having it in the scenario list (file/dict/db/etc), the goal being to have a central place with enough information to recreate a scenario (it can include pointers to external data, like we do with profile versions). Technically for full reproducibility we'd need to store a commit hash or something for the exact code that ran it, but that's for a different conversation. |
The ScenarioList is the way to go in my opinion. In the Analyze class, the grid model would be enclosed in the scenario info dict, as the engine, and can then be passed to the Grid class to instantiate an object based on the engine/model combo. |
@danielolsen Exactly, but in other situations, it might be more convenient to look up this info if it exists more than one place. |
grid model
column in the ScenarioList fileThe text was updated successfully, but these errors were encountered: