Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Modelmmutables to better represent non-USA grid models #591

Closed
1 task done
danielolsen opened this issue Mar 1, 2022 · 1 comment
Closed
1 task done
Assignees
Labels
feature request Request for a new feature. (Only lives in Backlog) refactor Code that is being refactored

Comments

@danielolsen
Copy link
Contributor

🚀

  • Is your feature request essential for your project?

Describe the workflow you want to enable

Currently, instantiating a Grid object requires a instantiation of a ModelImmutables object, which contains system-level constants. Information about generator types and default values for new storage is fine, but there's a lot of stuff in ModelImmutables.zones/zones.py that doesn't correspond primarily to zones (which matter to distribution of demand profiles to buses), but to higher-level areas like states or time zones, which don't necessarily apply to other regions. These sorts of information aren't important for the simulation, but are used for post-processing of results. The area_to_loadzone methods has some hard-coded references to states, and no references to other regions (e.g. countries, provinces).

Describe your proposed implementation

At the very least, area_to_loadzone needs a refactor to handle things like provinces, countries, etc. At the same time, we may want to reorganize the structure so that there can be some sets of information that are defined at a higher-level than just a grid model, e.g. information that's defined for a given region, or for given fuels, etc., rather than manually duplicating it within the subfolders of powersimdata.network. #566 did things quick-and-dirty, but there's definitely a lot that can be improved about the process of adding new grid models, like having as much data as possible stored in CSVs rather than python modules.

@danielolsen danielolsen added feature request Request for a new feature. (Only lives in Backlog) refactor Code that is being refactored labels Mar 1, 2022
@danielolsen danielolsen removed their assignment May 27, 2022
@merrielle
Copy link
Collaborator

Ben has finished this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature. (Only lives in Backlog) refactor Code that is being refactored
Projects
None yet
Development

No branches or pull requests

5 participants