Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running tests now creates a diff due to saved capacity scaling demo #185

Closed
danielolsen opened this issue May 20, 2020 · 2 comments · Fixed by #191
Closed

Running tests now creates a diff due to saved capacity scaling demo #185

danielolsen opened this issue May 20, 2020 · 2 comments · Fixed by #191
Labels
bug Something isn't working
Milestone

Comments

@danielolsen
Copy link
Contributor

When submitting/merging #184, I didn't update the changes to files in powersimdata/design/demo/data/save_files because I didn't think they mattered. But now whenever we run tests, these files are modified again and so now they create a diff from HEAD, precluding the use of helpful shortcuts like git add -u and requiring git reset HEAD --hard to rebase, change branches, etc.

Potential solutions:

  • Commit a change to these files
  • Modify .gitignore to ignore this folder
  • Have the tests clean up after themselves and delete the created files (then commit the deletion so that's not a diff)
@danielolsen danielolsen added the bug Something isn't working label May 20, 2020
@dmuldrew
Copy link
Collaborator

I suppose the .gitignore solution is probably the least work

@rouille
Copy link
Collaborator

rouille commented May 20, 2020

I noticed that the files were changed after running the tests. As @dmuldrew said, ignoring the folder via the .gitignore is the least work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants