Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for 'biomass' and 'other' generators, slight refactor #55

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

danielolsen
Copy link
Contributor

This adds support for analyzing 'biomass' and 'other' generators. There are a few places where I'm not sure if I did things the right way, particularly constants.py (@merrielle can you please look at these changes and make sure they don't break anything in plotting) and analyze_set.py (@rouille can you please look at these changes and make sure they don't break anything that we still use in this script).

@rouille
Copy link
Collaborator

rouille commented Dec 10, 2019

grid.py also needs modification. I will need to test the code to make sure that it works.

@danielolsen
Copy link
Contributor Author

@rouille see that PR here: Breakthrough-Energy/PowerSimData#71

@@ -9,11 +9,13 @@
}
SCENARIO_RESOURCE_TYPES = ['wind', 'solar', 'ng',
'coal', 'nuclear', 'geothermal', 'hydro']
ALL_RESOURCE_TYPES = SCENARIO_RESOURCE_TYPES + ['other inc. biomass']
ADDITIONAL_RESOURCE_TYPES = ['dfo', 'other inc. biomass', 'other', 'biomass']
Copy link
Collaborator

@merrielle merrielle Dec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding me onto the review. Since you're adding dfo and biomass to analyze_pg then you should put them in SCENARIO_RESOURCE_TYPES.

Now that I think about it, ADDITIONAL_RESOURCE_TYPES is a relic from my original spot check code and I need to remove it.

Also we should eventually take type2label and type2color out of analyze_pg so we don't have to have duplicates like this.

@rouille
Copy link
Collaborator

rouille commented Dec 13, 2019

When will we be able to test these changes. I believe the new Eastern base now has other as generator type (no biomass though) and we could use these scenarios to test the changes.

@danielolsen
Copy link
Contributor Author

When will we be able to test these changes. I believe the new Eastern base now has other as generator type (no biomass though) and we could use these scenarios to test the changes.

Scenario #307 is running, slowly. We'll probably have results to test by Monday morning.

@danielolsen
Copy link
Contributor Author

Tested successfully on Scenario #307. As a prerequisite, we need to have a version of powersimdata installed that contains the changes of both add_othertype_gens and add_biomass_other_support (a branch like this does not exist in github yet, I did some local rebasing to test).

@danielolsen danielolsen force-pushed the add_biomass_other_support branch from 90cf533 to 06ed2b4 Compare December 19, 2019 19:08
@danielolsen
Copy link
Contributor Author

This change has been successfully tested, and the dependencies have been merged into PowerSimData (see Breakthrough-Energy/PowerSimData#71 and Breakthrough-Energy/PowerSimData#72) so I think this change is ready to merge.

Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@danielolsen danielolsen force-pushed the add_biomass_other_support branch from 06ed2b4 to 3311cc6 Compare January 9, 2020 18:50
@danielolsen danielolsen merged commit e7dafdb into develop Jan 9, 2020
@danielolsen danielolsen deleted the add_biomass_other_support branch March 23, 2020 22:54
@ahurli ahurli mentioned this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants