Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into master for v0.5.2 release #348

Merged
merged 38 commits into from
Aug 18, 2022
Merged

Merge develop into master for v0.5.2 release #348

merged 38 commits into from
Aug 18, 2022

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Aug 18, 2022

Purpose

Merge develop into master for 0.5.2 release

Proposed release notes

Closed issues

Merged Pull Requests (features)

None

Merged Pull Requests (fixes, etc.)

kasparm and others added 30 commits March 10, 2022 19:00
Clean up tox file and fix warnings
Remove dependency on ScenarioInfo objects
@rouille rouille requested review from BainanXia and jenhagg August 18, 2022 18:51
@rouille rouille self-assigned this Aug 18, 2022
@jenhagg
Copy link
Collaborator

jenhagg commented Aug 18, 2022

How did you generate the release notes?

By hand, copying/pasting closed PRs and issues

@BainanXia
Copy link
Collaborator

How did you generate the release notes?

By hand, copying/pasting closed PRs and issues

Shouldn't it be generated automatically by Github?

@jenhagg
Copy link
Collaborator

jenhagg commented Aug 18, 2022

How did you generate the release notes?
By hand, copying/pasting closed PRs and issues

Shouldn't it be generated automatically by Github?

The way I do it is first using a custom git log command to get a sorted commit list (just to provide something useful). Then once develop -> master is merged, auto generate the release notes from the releases UI and update the PR description. Not sure if there is a better way, e.g. basing releases off develop or something.

@rouille
Copy link
Collaborator Author

rouille commented Aug 18, 2022

How did you generate the release notes?
By hand, copying/pasting closed PRs and issues

Shouldn't it be generated automatically by Github?

The way I do it is first using a custom git log command to get a sorted commit list (just to provide something useful). Then once develop -> master is merged, auto generate the release notes from the releases UI and update the PR description. Not sure if there is a better way, e.g. basing releases off develop or something.

I believe I always did some copy/paste. It would be nice to automate the process so this is consistent across release and packages.

@jenhagg
Copy link
Collaborator

jenhagg commented Aug 18, 2022

I believe I always did some copy/paste. It would be nice to automate the process so this is consistent across release and packages.

I'll look into it, been meaning to do that for a while.

@BainanXia
Copy link
Collaborator

I believe I always did some copy/paste. It would be nice to automate the process so this is consistent across release and packages.

I'll look into it, been meaning to do that for a while.

I never did it before but this is what I looked into before.

@rouille rouille merged commit 3568f49 into master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants