Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe scenarios used in tutorial #340

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Describe scenarios used in tutorial #340

merged 1 commit into from
Apr 19, 2022

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Apr 16, 2022

Pull Request doc

Purpose

Describe scenarios used in tutorial

What the code is doing

N/A

Testing

Run tox in the docs and checked in my browser that the new section is correctly displayed

Where to look

  • A new reStructuredText file enclosing the section describing the scenarios used in the tutorial is created
  • A link to the above file is created in the index

Usage Example/Visuals

Screen Shot 2022-04-15 at 11 03 27 PM

Time estimate

5min

@rouille rouille added the dependencies Pull requests that update a dependency file label Apr 16, 2022
@rouille rouille self-assigned this Apr 16, 2022
BainanXia
BainanXia approved these changes Apr 16, 2022
View reviewed changes
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked the scenario numbers and they looks good. I believe this closes #59.

@rouille rouille merged commit 1d49762 into develop Apr 19, 2022
@rouille rouille deleted the ben/docs branch April 19, 2022 16:32
@rouille rouille mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BainanXia BainanXia BainanXia approved these changes

@danielolsen danielolsen Awaiting requested review from danielolsen

@merrielle merrielle Awaiting requested review from merrielle

@jenhagg jenhagg Awaiting requested review from jenhagg

Assignees

@rouille rouille

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rouille @BainanXia