Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaging and docker related workflows #317

Merged
merged 6 commits into from
Sep 1, 2021
Merged

Update packaging and docker related workflows #317

merged 6 commits into from
Sep 1, 2021

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Aug 23, 2021

Purpose

Add the necessary bits to publish to PyPI and remove soon to be obsolete docker build.

What the code is doing

A few things are combined here for continuity:

  • new workflow to build and publish package to PyPI on new tags
  • remove docker build which is moved to plug, pending Move docker build to plug repo plug#25
  • specify the version of powersimdata to be installed from PyPI

For context, once we restrict the powersimdata version, the docker build as-is will no longer make sense - the image is inheriting from powersimdata:latest but then we will override that with whatever version matches the specifier.

Testing

Built the package locally, but mostly this is copy-paste from elsewhere.

Time estimate

15 min

@rouille
Copy link
Collaborator

rouille commented Aug 23, 2021

We will publish PreREISE and PostREISE on PyPi too? I mean, in addition to PowerSimData.

@jenhagg jenhagg marked this pull request as ready for review August 30, 2021 23:43
@jenhagg jenhagg self-assigned this Aug 30, 2021
@jenhagg
Copy link
Collaborator Author

jenhagg commented Aug 30, 2021

Support for building a "stable" docker image based on the latest published version of postreise is included in this draft PR Breakthrough-Energy/plug#29

Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We might want to update the PowerSimData version after it is released to 0.4.4

@jenhagg jenhagg requested a review from rouille September 1, 2021 20:42
Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good

@jenhagg jenhagg merged commit bc7cf47 into develop Sep 1, 2021
@jenhagg jenhagg deleted the jon/pypi branch September 1, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants