-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packaging and docker related workflows #317
Conversation
We will publish PreREISE and PostREISE on PyPi too? I mean, in addition to PowerSimData. |
Support for building a "stable" docker image based on the latest published version of postreise is included in this draft PR Breakthrough-Energy/plug#29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We might want to update the PowerSimData version after it is released to 0.4.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good
Purpose
Add the necessary bits to publish to PyPI and remove soon to be obsolete docker build.
What the code is doing
A few things are combined here for continuity:
For context, once we restrict the powersimdata version, the docker build as-is will no longer make sense - the image is inheriting from
powersimdata:latest
but then we will override that with whatever version matches the specifier.Testing
Built the package locally, but mostly this is copy-paste from elsewhere.
Time estimate
15 min