Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use ctrl-c to copy text in Vim binding mode #773

Open
HineBlack opened this issue Jan 27, 2021 · 3 comments
Open

Can't use ctrl-c to copy text in Vim binding mode #773

HineBlack opened this issue Jan 27, 2021 · 3 comments
Labels
bug 🐛 Issue concerns a bug. funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new!

Comments

@HineBlack
Copy link

HineBlack commented Jan 27, 2021

Issuehunt badges

Current behavior

I just switched from old Boostnote, and found I can's use ctrl+c to copy text into clipboard, which has been solved in old Boostnote issue #646.

Expected behavior

  1. Add a copy to clipboard to existing ctrl+c shortcut
  2. Change as to copy into clipboard on yank.
  3. Custom keybinding maybe, I personally prefer use Esc instead of ctrl+c to exit insert mode, in old Boostnote you can copy text with ctrl+c but it also exit insert mode, which is a little annoy for me.

Steps to reproduce

  1. insert some text in Vim insert mode, select some text, try press ctrl-c to copy them into clipboard
  2. exit from vim insert mode, select some text, try press y to yank them, but it's not show in clipboard

Environment

Desktop/Web

  • Boost Note.next version: 0.12.4
  • OS version and name: Windows 10

IssueHunt Summary

Backers (Total: $20.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips

@Komediruzecki Komediruzecki added the feature request 🌟 Issue is a new feature request. label Jan 27, 2021
@Rokt33r Rokt33r added bug 🐛 Issue concerns a bug. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! and removed feature request 🌟 Issue is a new feature request. labels Aug 20, 2021
@Rokt33r
Copy link
Member

Rokt33r commented Aug 20, 2021

The issue is still existing in Windows and Linux. It works fine in macOS since its copying shortcut is using Super(Cmd) + C instead of Ctrl + C.

How to fix

Just like the below link, adding an extra key should fix the issue.

https://github.com/BoostIO/Boostnote/pull/649/files#diff-7890cda3f01d76c730b641b51aca870a682d84971add9f45e9e22fc9cac46dc1R88-R93

Adding the code above to here should fix this issue.

@Komediruzecki
Copy link
Contributor

@Rokt33r

But does that mean that ctrl+c cannot really be used as an exit? Since some users might want to use this shortcut instead of escape.

I suppose it would be best to add a custom keymap for a copy so that users can use the default copy in VIM mode but also change it if they prefer exiting with that shortcut (or unset it).

I can easily add this to local space since it already has the implementation of keymaps, but for cloud, probably once it's ported?
Or if we want the fix straight away, as suggested?

@issuehunt-oss
Copy link

issuehunt-oss bot commented Sep 14, 2021

@boostio has funded $20.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. label Sep 14, 2021
@kazup01 kazup01 added the hacktoberfest Contribute to the Boost Note and grab the swags! https://hacktoberfest.digitalocean.com/ label Oct 4, 2021
@kazup01 kazup01 removed the hacktoberfest Contribute to the Boost Note and grab the swags! https://hacktoberfest.digitalocean.com/ label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug. funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new!
Projects
None yet
Development

No branches or pull requests

4 participants