Skip to content
This repository has been archived by the owner on Apr 28, 2023. It is now read-only.

refactor: fix complete swap reducers #90

Merged
merged 11 commits into from
Feb 19, 2019
Merged

refactor: fix complete swap reducers #90

merged 11 commits into from
Feb 19, 2019

Conversation

ImmanuelSegol
Copy link
Contributor

@ImmanuelSegol ImmanuelSegol commented Feb 16, 2019 •
edited
Loading

This PR takes care of:

  1. reducer issue

@ghost ghost assigned ImmanuelSegol Feb 16, 2019
@ghost ghost added the in progress label Feb 16, 2019
michael1011
michael1011 suggested changes Feb 16, 2019
View reviewed changes
Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't fix the problem for me. The swapReducer still has values after a successful swap:

image

@ImmanuelSegol
Copy link
Contributor Author

@michael1011 This is supposed to fix the reducer issue, and I also fix issue #95

michael1011
michael1011 suggested changes Feb 19, 2019
View reviewed changes
Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few little issues I pointed out in my comments.

And the normal Swap reducer gets cleared properly now but the reverse one is still not being reset to its initial state.

@michael1011 michael1011 merged commit 168472d into master Feb 19, 2019
@ghost ghost removed the in progress label Feb 19, 2019
@michael1011 michael1011 deleted the reducer-fix branch February 19, 2019 22:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michael1011 michael1011 michael1011 approved these changes

@peartobear peartobear Awaiting requested review from peartobear

Assignees

@ImmanuelSegol ImmanuelSegol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImmanuelSegol @michael1011