Skip to content
This repository has been archived by the owner on Apr 28, 2023. It is now read-only.

feat: dont include middleware in production build #89

Merged
merged 2 commits into from
Feb 17, 2019
Merged

feat: dont include middleware in production build #89

merged 2 commits into from
Feb 17, 2019

Conversation

ImmanuelSegol
Copy link
Contributor

@ImmanuelSegol ImmanuelSegol commented Feb 15, 2019 •
edited
Loading

Dont include middleware in production build

@ghost ghost assigned ImmanuelSegol Feb 15, 2019
@ghost ghost added the in progress label Feb 15, 2019
michael1011
michael1011 reviewed Feb 16, 2019
View reviewed changes
Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate a bit on what effects this change will have?

@ImmanuelSegol
Copy link
Contributor Author

Could you elaborate a bit on what effects this change will have?

@michael1011 This disables specific middleware when we deploy the app.

@michael1011 michael1011 merged commit 5fede40 into master Feb 17, 2019
@michael1011 michael1011 deleted the middelware branch February 17, 2019 18:37
@ghost ghost removed the in progress label Feb 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michael1011 michael1011 michael1011 approved these changes

@peartobear peartobear Awaiting requested review from peartobear

Assignees

@ImmanuelSegol ImmanuelSegol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImmanuelSegol @michael1011