Skip to content
This repository has been archived by the owner on Apr 28, 2023. It is now read-only.

feat: integrate circleci #88

Merged
merged 8 commits into from
Feb 16, 2019
Merged

feat: integrate circleci #88

merged 8 commits into from
Feb 16, 2019

Conversation

ImmanuelSegol
Copy link
Contributor

No description provided.

@ghost ghost assigned ImmanuelSegol Feb 15, 2019
@ghost ghost added the in progress label Feb 15, 2019
michael1011
michael1011 suggested changes Feb 15, 2019
View reviewed changes
Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's run Travis and CircleCI in parallel and pick whatever works best for us

michael1011
michael1011 approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more question before this can be merged

@ImmanuelSegol ImmanuelSegol merged commit 65241b4 into master Feb 16, 2019
@ghost ghost removed the in progress label Feb 16, 2019
@ImmanuelSegol ImmanuelSegol deleted the circle-ci branch February 16, 2019 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michael1011 michael1011 michael1011 approved these changes

@peartobear peartobear Awaiting requested review from peartobear

Assignees

@ImmanuelSegol ImmanuelSegol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImmanuelSegol @michael1011