This repository has been archived by the owner on Apr 28, 2023. It is now read-only.
feat: more versatile errors on homepage #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
michael1011
suggested changes
Feb 5, 2019
| onPress={error ? () => {} : () => this.shouldSubmit()} | ||
| errorText={'Invalid amount'} | ||
| errorText={inputError ? 'Invalid amount' : errorMessage} |
There was a problem hiding this comment.
Do you think it is fine to have Invalid amount as default error? Would it be better to get rid of the error boolean and just have the string errorText that determines whether there is an error and sets the text of the button?
There was a problem hiding this comment.
@michael1011 My idea was that the input error would always override any other error.
There was a problem hiding this comment.
Yeah that sounds reasonable.
michael1011
approved these changes
Feb 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #71