This repository has been archived by the owner on Apr 28, 2023. It is now read-only.
feat: add loading state to swaptab #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael1011
reviewed
Dec 29, 2018
Co-Authored-By: ImmanuelSegol <[email protected]>
ghost
assigned
michael1011
approved these changes
Dec 30, 2018
There was a problem hiding this comment.
Regarding the design: I think just the logo is fine. Maybe we can add some cool animation in the future but there are more important things right now.
Feel free to create an issue for that so that we don't forget about it. Also I am really bad when it comes to design and UI so I would appreciate some ideas of how it could look like 😉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
I think we should discuss the UI design of this one