This repository has been archived by the owner on Apr 28, 2023. It is now read-only.
fix: trim "lightning:" prefix of invoices #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe some quick research on it's status to become a standard? If so we should treat it differently. Couldn't find anything in a quick search tho. |
@armurbalda it's just a prefix for the invoice so that, if it's a link, the lightning wallets know that the invoice should be opened by them. If one remove removes the |
michael1011
force-pushed
the
trim-lightning-prefix
branch
from
80de1b8 to
cc6b360
Compare
michael1011
force-pushed
the
trim-lightning-prefix
branch
from
cc6b360 to
4b093f1
Compare
peartobear
approved these changes
Apr 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BoltzExchange/boltz-backend#102
The
lightning:prefix will be valid in the input field for the invoice and removed before making the request to the middleware.