Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden Tagline = Empty Heading Tag = Bad for Accessibility #52

Closed
nicolepaschen opened this issue Oct 11, 2022 · 1 comment · Fixed by #58 or #61
Closed

Hidden Tagline = Empty Heading Tag = Bad for Accessibility #52

nicolepaschen opened this issue Oct 11, 2022 · 1 comment · Fixed by #58 or #61
Labels
bug Something isn't working

Comments

@nicolepaschen
Copy link
Member

image

image

If the tagline isn't showing in the active header layout, do not display the h3 at all in the code please
@jamesros161 jamesros161 added the bug Something isn't working label Oct 24, 2022
@jamesros161
Copy link
Collaborator

A better solution would be for us to add the 'aria-hidden=true' attribute to an empty tagline. This will prevent issues in regards to affecting the overall operation of this feature.

@jamesros161 jamesros161 added this to the 2.19.1 milestone Jan 9, 2023
@jamesros161 jamesros161 removed this from the milestone Jan 18, 2023
@jamesros161 jamesros161 added this to the 2.20.0 milestone Mar 28, 2023
@jamesros161 jamesros161 transferred this issue from BoldGrid/boldgrid-theme-framework Mar 28, 2023
This was referenced Mar 31, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 52 - add aria-hidden to taglines not shown BoldGrid/crio
Branch 2.20.0 BoldGrid/crio
2 participants
@nicolepaschen @jamesros161