Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with edit buttons on blog page content #438

Closed
nicolepaschen opened this issue Jul 14, 2021 · 11 comments
Closed

Bug with edit buttons on blog page content #438

nicolepaschen opened this issue Jul 14, 2021 · 11 comments
Milestone

Comments

@nicolepaschen
Copy link
Member

I used the WP unit test data and the homepage is set to posts. When I click the buttons it always takes me to the Featured Image panel instead of the specific element I'm on.

Before I clicked the buttons by the post content, I clicked the body background button and I got overlapping panels in the Customizer (first part of gif)

nothing-happens

@nicolepaschen
Copy link
Member Author

The edit button by the post titles on the blog page should go to Design > Blog > Blog Page > Titles

image

@nicolepaschen
Copy link
Member Author

Please have all these buttons go to Design > Blog > Blog Page > Post Meta

Screenshot_1

@nicolepaschen
Copy link
Member Author

These two buttons aren't quite where I'd expect them - could they be in the upper corner?

odd-placement

@jamesros161
Copy link
Contributor

The exact positioning of the buttons is not going to always be where we want them, they get moved in order to prevent overlapping other edit buttons

@jamesros161 jamesros161 added this to the Beta milestone Jul 23, 2021
@nicolepaschen
Copy link
Member Author

The buttons by the sidebar widget links goes to the wrong panel. It currently goes to Body Links but they have their own control under Primary Sidebar > Links Color.

widget-links

@nicolepaschen
Copy link
Member Author

The button on Post Page Titles should have a link to Page Title Styling as well.

page-title-styling

@nicolepaschen
Copy link
Member Author

When using the Starter Content or Inspirations, there are buttons in the Post Meta that go to Body Links. Most times these links are controlled by Body Links but sometimes Inspirations use the config specifically set at Design > Blog > Blog Page > Post Meta

blog-controls

When I use the WP Unit test data, these buttons do not appear:
no-extra-things

@nicolepaschen
Copy link
Member Author

Post Navigation links at the bottom of each post currently have a Body Link button but they have their own control at Design > Blog > Posts > Links > Post Navigation Links

Screenshot_2

@nicolepaschen
Copy link
Member Author

Pages have an option for background, container, sidebar but Posts are missing the background and container - sidebar is a separate button:

missing-post-container

@nicolepaschen
Copy link
Member Author

I cannot find a button for the container on Posts. There is a link to the Container/Background/Sidebar on pages. On posts, the sidebar has a separate button.

@nicolepaschen
Copy link
Member Author

nicolepaschen commented Aug 3, 2021

The buttons on the Blog Page go on top of the Sticky Header, except for the post with the image it appears:

post-meta-sticky-header

Other buttons go on top of the Sticky Header as well
Screenshot_1

@jamesros161 jamesros161 linked a pull request Aug 9, 2021 that will close this issue
@jamesros161 jamesros161 removed a link to a pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants