Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac workaround can likely come out now #62

Closed
bdraco opened this issue Apr 19, 2023 · 4 comments
Closed

Mac workaround can likely come out now #62

bdraco opened this issue Apr 19, 2023 · 4 comments

Comments

@bdraco
Copy link
Member

bdraco commented Apr 19, 2023

self.mac_known = sys.platform != "darwin"

HA now enables the flag to give the real mac

@Ernst79
Copy link
Collaborator

Ernst79 commented May 5, 2023

So, the mac address is now always available in the data, also on a mac?

@koenvervloesem
Copy link

koenvervloesem commented May 5, 2023

This won't work always, I have seen a program crash when enabling this feature with Bleak on a macOS version that doesn't support the undocumented API.

@Ernst79
Copy link
Collaborator

Ernst79 commented Oct 13, 2023

@bdraco So, based on the message of @koenvervloesem, should we keep the MAC workaround in for now?

@bdraco
Copy link
Member Author

bdraco commented Oct 13, 2023

We have the bdaddr featured turned on unconditionally in HA and don't have any plans to support older MacOS so I think it can come out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants