feat: verify packet is not an older packet #112
Merged
+154
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
reviewed
Mar 1, 2024
src/bthome_ble/parser.py
Outdated
Comment on lines
449
to
453
| elif ( | ||
| last_packet_id is not None | ||
| and new_packet_id <= last_packet_id | ||
| and last_packet_id - new_packet_id < 128 | ||
| ): |
There was a problem hiding this comment.
I'd make this a named function to better show intent and document with a docstring its handling the packet id wrapping
There was a problem hiding this comment.
I also moved the logic for comparing packet time to make it clear what are the conditions for dropping a packet
bdraco
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 80.92% 81.28% +0.36%
==========================================
Files 6 6
Lines 519 529 +10
Branches 79 82 +3
==========================================
+ Hits 420 430 +10
Misses 78 78
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Ernst79
approved these changes
Mar 2, 2024
Co-authored-by: Ernst Klamer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.