Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pypi upload #202

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: pypi upload #202

merged 1 commit into from
Feb 4, 2025

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Feb 4, 2025

Even though the last CI run successfully created the 0.21.3 tag, no release files were uploaded to PyPI.
https://github.com/Bluetooth-Devices/bluetooth-adapters/actions/runs/13137668273/job/36656979158
https://pypi.org/project/bluetooth-adapters/

Add the missing CI steps according to the python-semantic-release documentation.
https://python-semantic-release.readthedocs.io/en/latest/automatic-releases/github-actions.html#common-workflow-example

Note

This requires trusted publisher to be setup.
https://docs.pypi.org/trusted-publishers/adding-a-publisher/

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.05%. Comparing base (97467d3) to head (0f09bf7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   91.05%   91.05%           
=======================================
  Files          14       14           
  Lines         503      503           
  Branches       49       49           
=======================================
  Hits          458      458           
  Misses         36       36           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member

bdraco commented Feb 4, 2025

There is already a trusted publisher set up for this package so it should just work with this change

@bdraco bdraco merged commit 5b90015 into Bluetooth-Devices:main Feb 4, 2025
21 checks passed
@cdce8p cdce8p deleted the fix-pypi-upload branch February 4, 2025 18:24
@cdce8p
Copy link
Contributor Author

cdce8p commented Feb 4, 2025

There is already a trusted publisher set up for this package so it should just work with this change

Looks good now.
https://pypi.org/project/bluetooth-adapters/0.21.4/#files
https://github.com/Bluetooth-Devices/bluetooth-adapters/releases/tag/v0.21.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants