Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated checks can be replaced by modifier #1

Open
ryu9827 opened this issue May 8, 2018 · 0 comments
Open

Repeated checks can be replaced by modifier #1

ryu9827 opened this issue May 8, 2018 · 0 comments

Comments

@ryu9827
Copy link

ryu9827 commented May 8, 2018

Checks for contract owner and user existence are repeated for many times in different functions in ProofOfPhysicalAddress.sol. Suggest to use a modifier to replace repeated codes.
Check for contract owner :
Line61, Line66, Line74, Line83

Check for user existence:
Line97, Line111, Line129, Line147, Line161, Line169, Line204, Line221, Line293, Line325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant