Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: pfff #2986

Closed
vdun opened this issue Jan 15, 2021 · 4 comments
Closed

Update: pfff #2986

vdun opened this issue Jan 15, 2021 · 4 comments
Labels
complexity::high A bug that is hard to fix type::tool-outdated When a package need to be updated because the tool was updated

Comments

@vdun
Copy link
Contributor

vdun commented Jan 15, 2021

pfff from facebook is archived: https://github.com/facebook/pfff -> https://github.com/facebookarchive/pfff
pfff is now here: https://github.com/returntocorp/pfff

Please update: https://github.com/BlackArch/blackarch/tree/master/packages/pfff

Many thanks guys for your great efforts!

@vdun vdun added the type::bug Valid bug label Jan 15, 2021
@pwnfoo
Copy link
Member

pwnfoo commented Jan 18, 2021

More info:
A lot of changes have gone into the new pfff since the new release, so will have to validate if the patches are still relevant.

external/ocamlzip folder no longer exists too, so the current PKGBUILD will have to be rewritten.

@pwnfoo pwnfoo added the complexity::high A bug that is hard to fix label Jan 18, 2021
@noraj noraj added type::tool-outdated When a package need to be updated because the tool was updated and removed type::bug Valid bug labels Sep 16, 2022
@D3vil0p3r
Copy link
Contributor

D3vil0p3r commented Jan 5, 2023

It has been migrated here: https://github.com/returntocorp/semgrep/blob/develop/semgrep-core/src/pfff/README.md

I just opened an issue ticket there for understanding if the tool is still maintained or not.

@D3vil0p3r
Copy link
Contributor

Here an update: semgrep/semgrep#6781 (comment)

@noraj At this point pfff should be removed?

@noraj
Copy link
Contributor

noraj commented Jan 7, 2023

Here an update: returntocorp/semgrep#6781 (comment)

@noraj At this point pfff should be removed?

Yes. At the light of semgrep/semgrep#6781, I think pfff (at least for now) is just a core component of semgrep and has no purpose alone. So now that the pfff repo was removed we can't add it to the deprecated list and remove the pfff package dependency of pfff since pfff is now included in semgrep itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity::high A bug that is hard to fix type::tool-outdated When a package need to be updated because the tool was updated
Projects
None yet
Development

No branches or pull requests

4 participants