[net processing] Rename nStartingHeight to m_starting_height

Summary:
```
Not done as a scripted diff to avoid misnaming the local variable in
ProcessMessage().
```

Partial backport of [[ bitcoin/bitcoin#19829 | core#19829 ]]:
bitcoin/bitcoin@78040f9

Depends on D10866.

Ref T1696.

Test Plan:
  ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Subscribers: PiRK

Maniphest Tasks: T1696

Differential Revision: https://reviews.bitcoinabc.org/D10867

Author: jnewbery

src/net.h

@@ -789,7 +789,7 @@ struct CNodeStats {
     std::string cleanSubVer;
     bool fInbound;
     bool m_manual_connection;
-    int nStartingHeight;
+    int m_starting_height;
     uint64_t nSendBytes;
     mapMsgCmdSize mapSendBytesPerMsgCmd;
     uint64_t nRecvBytes;

src/net_processing.cpp

@@ -1215,7 +1215,7 @@ bool PeerManager::GetNodeStateStats(NodeId nodeid, CNodeStateStats &stats) {
     if (peer == nullptr) {
         return false;
     }
-    stats.nStartingHeight = peer->nStartingHeight;
+    stats.m_starting_height = peer->m_starting_height;
 
     return true;
 }
@@ -2410,7 +2410,7 @@ void PeerManager::ProcessHeadersMessage(
             LogPrint(
                 BCLog::NET,
                 "more getheaders (%d) to end to peer=%d (startheight:%d)\n",
-                pindexLast->nHeight, pfrom.GetId(), peer.nStartingHeight);
+                pindexLast->nHeight, pfrom.GetId(), peer.m_starting_height);
             m_connman.PushMessage(
                 &pfrom, msgMaker.Make(NetMsgType::GETHEADERS,
                                       ::ChainActive().GetLocator(pindexLast),
@@ -2939,7 +2939,7 @@ void PeerManager::ProcessMessage(const Config &config, CNode &pfrom,
         ServiceFlags nServices;
         int nVersion;
         std::string cleanSubVer;
-        int nStartingHeight = -1;
+        int starting_height = -1;
         bool fRelay = true;
         uint64_t nExtraEntropy = 1;
 
@@ -2977,7 +2977,7 @@ void PeerManager::ProcessMessage(const Config &config, CNode &pfrom,
             cleanSubVer = SanitizeString(strSubVer);
         }
         if (!vRecv.empty()) {
-            vRecv >> nStartingHeight;
+            vRecv >> starting_height;
         }
         if (!vRecv.empty()) {
             vRecv >> fRelay;
@@ -3021,7 +3021,7 @@ void PeerManager::ProcessMessage(const Config &config, CNode &pfrom,
             LOCK(pfrom.cs_SubVer);
             pfrom.cleanSubVer = cleanSubVer;
         }
-        peer->nStartingHeight = nStartingHeight;
+        peer->m_starting_height = starting_height;
 
         // set nodes not relaying blocks and tx and not serving (parts) of the
         // historical blockchain as "clients"
@@ -3110,7 +3110,7 @@ void PeerManager::ProcessMessage(const Config &config, CNode &pfrom,
                  "receive version message: [%s] %s: version %d, blocks=%d, "
                  "us=%s, peer=%d%s\n",
                  pfrom.addr.ToString(), cleanSubVer, pfrom.nVersion,
-                 peer->nStartingHeight, addrMe.ToString(), pfrom.GetId(),
+                 peer->m_starting_height, addrMe.ToString(), pfrom.GetId(),
                  remoteAddr);
 
         // Ignore time offsets that are improbable (before the Genesis block)
@@ -3150,7 +3150,7 @@ void PeerManager::ProcessMessage(const Config &config, CNode &pfrom,
             LogPrintf(
                 "New outbound peer connected: version: %d, blocks=%d, "
                 "peer=%d%s (%s)\n",
-                pfrom.nVersion.load(), peer->nStartingHeight, pfrom.GetId(),
+                pfrom.nVersion.load(), peer->m_starting_height, pfrom.GetId(),
                 (fLogIPs ? strprintf(", peeraddr=%s", pfrom.addr.ToString())
                          : ""),
                 pfrom.m_tx_relay == nullptr ? "block-relay" : "full-relay");
@@ -5363,7 +5363,8 @@ bool PeerManager::SendMessages(const Config &config, CNode *pto,
                 LogPrint(
                     BCLog::NET,
                     "initial getheaders (%d) to peer=%d (startheight:%d)\n",
-                    pindexStart->nHeight, pto->GetId(), peer->nStartingHeight);
+                    pindexStart->nHeight, pto->GetId(),
+                    peer->m_starting_height);
                 m_connman.PushMessage(
                     pto, msgMaker.Make(NetMsgType::GETHEADERS,
                                        ::ChainActive().GetLocator(pindexStart),

src/net_processing.h

@@ -46,7 +46,7 @@ struct CNodeStateStats {
     int m_misbehavior_score = 0;
     int nSyncHeight = -1;
     int nCommonHeight = -1;
-    int nStartingHeight = -1;
+    int m_starting_height = -1;
     std::vector<int> vHeightInFlight;
 };
 
@@ -76,7 +76,7 @@ struct Peer {
     bool m_should_discourage GUARDED_BY(m_misbehavior_mutex){false};
 
     /** This peer's reported block height when we connected */
-    std::atomic<int> nStartingHeight{-1};
+    std::atomic<int> m_starting_height{-1};
 
     /**
      * Set of txids to reconsider once their parent transactions have been

src/qt/rpcconsole.cpp

@@ -1326,7 +1326,7 @@ void RPCConsole::updateDetailWidget() {
         }
 
         ui->peerHeight->setText(
-            QString::number(stats->nodeStateStats.nStartingHeight));
+            QString::number(stats->nodeStateStats.m_starting_height));
     }
 
     ui->detailWidget->show();

src/rpc/net.cpp

@@ -273,7 +273,7 @@ static RPCHelpMan getpeerinfo() {
                     obj.pushKV("addnode", stats.m_manual_connection);
                 }
                 if (fStateStats) {
-                    obj.pushKV("startingheight", statestats.nStartingHeight);
+                    obj.pushKV("startingheight", statestats.m_starting_height);
                     obj.pushKV("synced_headers", statestats.nSyncHeight);
                     obj.pushKV("synced_blocks", statestats.nCommonHeight);
                     UniValue heights(UniValue::VARR);