Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample reporter #93

Closed
NielsNicolai opened this issue Feb 1, 2021 · 4 comments
Closed

Sample reporter #93

NielsNicolai opened this issue Feb 1, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@NielsNicolai
Copy link
Contributor

The person reporting a sample is not necessarily the same as the person providing the measurement analysis result. Therefore I would suggest adding the reporterID field also to the Sample table. Makes sense?

@NielsNicolai NielsNicolai added the enhancement New feature or request label Feb 1, 2021
@vipileggi
Copy link
Contributor

@DougManuel @NielsNicolai I agree and makes sense to maintain a link between Sample and Reporter tables. I would recommend we proceed with this change.

@jeandavidt
Copy link
Collaborator

This issue is closed, but reporterID is not in the columns list for the table Sample in variables.csv
Can this be patched directly in main?

@jeandavidt jeandavidt reopened this Mar 24, 2021
@DougManuel
Copy link
Contributor

Yes, just make a hot fix to main.

@jeandavidt
Copy link
Collaborator

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants