Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstrumentID for the Sample table #104

Closed
NielsNicolai opened this issue Feb 25, 2021 · 2 comments
Closed

InstrumentID for the Sample table #104

NielsNicolai opened this issue Feb 25, 2021 · 2 comments
Assignees
@NielsNicolai
Labels
enhancement New feature or request
Milestone
v1.1.0

Comments

@NielsNicolai
Copy link
Contributor

My colleagues have provided me with some technical information on how the autosamplers work. They wanted to add that to the data model, yet they noticed that there is no InstrumentID for a sample. I think it would make sense to also add it to the Sample table.
@NielsNicolai NielsNicolai added the enhancement New feature or request label Feb 25, 2021
@DougManuel DougManuel added this to the v1.1.0 milestone Mar 1, 2021
@vipileggi vipileggi assigned vipileggi and unassigned vipileggi Mar 2, 2021
@vipileggi
Copy link
Contributor

@NielsNicolai agree a good idea to validate sample collection process.

@NielsNicolai
Copy link
Contributor Author

Done with this commit

@NielsNicolai NielsNicolai self-assigned this Mar 10, 2021
@DougManuel DougManuel mentioned this issue Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NielsNicolai NielsNicolai

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
3 participants
@DougManuel @NielsNicolai @vipileggi