Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample index #103

Closed
NielsNicolai opened this issue Feb 25, 2021 · 4 comments
Closed

Sample index #103

NielsNicolai opened this issue Feb 25, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@NielsNicolai
Copy link
Contributor

The Sample table does not efficiently describe replicate samples. For example, when you take multiple grab samples on the same day at the same location. Therefore I would suggest adding an index field to this table, similar to the one in the WWMeasure table.

@NielsNicolai NielsNicolai added the enhancement New feature or request label Feb 25, 2021
@DougManuel DougManuel added this to the v1.1.0 milestone Mar 1, 2021
@vipileggi
Copy link
Contributor

@NielsNicolai yes agree but the experience from MECP is that this index is not being used properly and we need some other built in key(s) as a redundant way to get this information when we aggregate the worksheets.

@NielsNicolai
Copy link
Contributor Author

Hi @vipileggi, how is it used at the moment?
One way of dibble checking whether it's a replicate or not is by validating if the date, site and type combination already exists. Yet this can only be done in the data validation/post-processing I think.

@NielsNicolai
Copy link
Contributor Author

Included with this commit

@vipileggi
Copy link
Contributor

Hi @NielsNicolai on #103 (comment)
that is what I've done as a temporary hack or workaround but not ideal. We had some MECP internal discussion on this and decided to try and communicate back to the users to clarify the use of the index variable and still necessary and can't think of a better way at the moment.

@NielsNicolai NielsNicolai self-assigned this Mar 10, 2021
@DougManuel DougManuel mentioned this issue Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants