modbus-server's input message can not operate well, So I modified the modbus-server-core.js , fixed these bugs

[wei1224hf]

Which node-red-contrib-modbus version are you using?

5.26.0

What happened?

The Modbus-Server node , can not operate well if I input messages into this node ,
It operates well with modbus-read and modbus-write node , based on modbus-client node,
but these operates are about AO and DO , can not operate DI and AI ,

If I want to modify the DI and AI data , I have to use input discrete regisnter type to send message into the modbus-server node,
although the DI and AI will change , but the address are wrong .

So I modify the modbus-server-core.js , fixed the bugs , to make it work well

Server

Modbus-Server Node

How can this be reproduced?

create a modbus-server node , send message into it with :

msg.payload = { 'value': 1234, 'register': 'holding', 'address': 1 , 'disableMsgOutput' : 0 };

then check the data with modbuscan32 , find there is a 1234 but the address is wrong.

What did you expect to happen?

No response

Other Information

I have already fixed the bugs by modifying the modbus-server-core.js

[grewek]

hi @wei1224hf,

first of thank you for your contribution, do you think you could make a pull request? it's easier for me to take a look at the changes made :)

Thank you!

[biancode]

@wei1224hf thank you for your contribution and for sharing your code! I've tested the changes and noticed some issues with the test suite. To maintain our quality standards and ensure compatibility for all users, we have a few requirements for contributions:

1. Please fork the repository and make your changes there
2. Ensure all tests pass (npm test)
3. Run the linter (npm run build)
4. Verify the changes don't break existing use cases
5. Submit a Pull Request with your improvements watch these Instructions

I'm happy to review your PR and provide feedback. Let me know if you need any help with the testing setup or have questions about our contribution process.
Looking forward to your PR! 👍

see the CONTRIBUTION.md

[biancode]

The changes are in the feature branch core_server_changes

[github-actions]

This issue is stale because it has been open 60 days with no activity. It will be closed in 30 days, but can be saved by removing the stale label or commenting.