From 05c46be23f638808ce5098a7a0c39e4d56239612 Mon Sep 17 00:00:00 2001 From: Ishaan Jaff Date: Fri, 17 Jan 2025 07:39:49 -0800 Subject: [PATCH 1/2] fix custom logger --- litellm/integrations/datadog/datadog_llm_obs.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/litellm/integrations/datadog/datadog_llm_obs.py b/litellm/integrations/datadog/datadog_llm_obs.py index 58d16aff3e2b..97226c6add9f 100644 --- a/litellm/integrations/datadog/datadog_llm_obs.py +++ b/litellm/integrations/datadog/datadog_llm_obs.py @@ -16,6 +16,7 @@ import litellm from litellm._logging import verbose_logger from litellm.integrations.custom_batch_logger import CustomBatchLogger +from litellm.integrations.datadog.datadog import DataDogLogger from litellm.llms.custom_httpx.http_handler import ( get_async_httpx_client, httpxSpecialProvider, @@ -24,7 +25,7 @@ from litellm.types.utils import StandardLoggingPayload -class DataDogLLMObsLogger(CustomBatchLogger): +class DataDogLLMObsLogger(DataDogLogger, CustomBatchLogger): def __init__(self, **kwargs): try: verbose_logger.debug("DataDogLLMObs: Initializing logger") @@ -52,7 +53,7 @@ def __init__(self, **kwargs): asyncio.create_task(self.periodic_flush()) self.flush_lock = asyncio.Lock() self.log_queue: List[LLMObsPayload] = [] - super().__init__(**kwargs, flush_lock=self.flush_lock) + CustomBatchLogger.__init__(self, **kwargs, flush_lock=self.flush_lock) except Exception as e: verbose_logger.exception(f"DataDogLLMObs: Error initializing - {str(e)}") raise e @@ -89,11 +90,8 @@ async def async_send_batch(self): "data": DDIntakePayload( type="span", attributes=DDSpanAttributes( - ml_app="litellm", - tags=[ - "service:litellm", - f"env:{os.getenv('DD_ENV', 'production')}", - ], + ml_app=self._get_datadog_service(), + tags=[self._get_datadog_tags()], spans=self.log_queue, ), ), From 17a4a3d866ecc05a19bae62882f8e74d7dfeb707 Mon Sep 17 00:00:00 2001 From: Ishaan Jaff Date: Fri, 17 Jan 2025 09:03:18 -0800 Subject: [PATCH 2/2] fix debugging dd llm obs --- litellm/integrations/datadog/datadog_llm_obs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/litellm/integrations/datadog/datadog_llm_obs.py b/litellm/integrations/datadog/datadog_llm_obs.py index 97226c6add9f..18744fa6ee96 100644 --- a/litellm/integrations/datadog/datadog_llm_obs.py +++ b/litellm/integrations/datadog/datadog_llm_obs.py @@ -96,7 +96,7 @@ async def async_send_batch(self): ), ), } - verbose_logger.debug("payload", json.dumps(payload, indent=4)) + verbose_logger.debug("payload %s", json.dumps(payload, indent=4)) response = await self.async_client.post( url=self.intake_url, json=payload,