Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional metadata to TreeNodeManifest #730

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Dec 21, 2023

Users may want to specify additional data for a node ("metadata"). They now have the option to do this, and this "metadata" will be a part of the automatically created XML when calling writeTreeNodesModelXML.

Note: we no longer need BT::TreeNodeManifest::description since this can be captured in the new metadata field, so I have deleted description.

include/behaviortree_cpp/basic_types.h Outdated Show resolved Hide resolved
include/behaviortree_cpp/bt_factory.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@facontidavide facontidavide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some request for changes.

include/behaviortree_cpp/tree_node.h Outdated Show resolved Hide resolved
include/behaviortree_cpp/bt_factory.h Outdated Show resolved Hide resolved
src/xml_parsing.cpp Outdated Show resolved Hide resolved
include/behaviortree_cpp/basic_types.h Outdated Show resolved Hide resolved
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though of course approval is not on me here.

include/behaviortree_cpp/bt_factory.h Show resolved Hide resolved
src/xml_parsing.cpp Show resolved Hide resolved
@facontidavide facontidavide merged commit 994650d into BehaviorTree:master Jan 10, 2024
@adlarkin adlarkin deleted the add_metadata branch January 10, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants