Check for / install GTest even if using catkin or ament #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facontidavide
added a commit
that referenced
this pull request
Nov 22, 2022
|
change merged, thanks! |
|
reverted. It breaks compilation in ROS |
|
Ah, in ROS1? I'll try to find something that works for both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could very well be missing something here, but creating a PR just in case.
Builds with colcon were failing for me with
gtest/gtest.h file not foundPreviously gtest was checked for / installed in an
elseif(BUILD_UNIT_TESTS)block, which would only trigger if neither ament or catkin were found.All this PR does is change the
elseif(BUILD_UNIT_TESTS)to anif(BUILD_UNIT_TESTS), which fixed my build issues.@facontidavide Does this look ok? Or am I missing something else?