Adding ForceRunningNode Decorator #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Martin Rico <[email protected]>
Signed-off-by: Francisco Martin Rico <[email protected]>
Signed-off-by: Francisco Martin Rico <[email protected]>
|
I prefer a different name. Since this reminds me RepeatUntilSuccesfull (with infinite retry). What about KeepRunningUntilFailure ? |
Signed-off-by: Francisco Martin Rico <[email protected]>
It's ok for me. changed ;) |
Signed-off-by: Francisco Martin Rico <[email protected]>
Signed-off-by: Francisco Martin Rico <[email protected]>
|
cool, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Davide!!
While working in a PR for Navigation2, I found useful to develop this decorator node.
The idea is continuing ticking a node unless it returns FAILURE, even if it returns RUNNING. I think that this completes the series ForceFailureNode and ForceSuccessNode.
I hope it helps!!!
Best
Signed-off-by: Francisco Martin Rico [email protected]