-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 2.9.0 causes Android build failure: COMPILETODALVIK PARSE error #74
Comments
This is a problem on the Xamarin side. Since Exoplayer 2.9.0 uses Java 8 it can't compile everything correctly. Microsoft will probably fix this in Visual Studio v15.10 A possible workaround could be to add |
Thanks for the reply. Unfortunately, I get a class not defined error with the "desugaring" enabled:
I will wait for Microsoft to hopefully fix this soon. |
I get almost identical behaviour, the only difference is that before |
I'm assuming that v15.0 is a Windows version reference? The latest VS for Mac Community (v7.6.10b27) is broken as well. |
Possible fix is here: https://twitter.com/_JonDouglas/status/1060691432401321984 |
It seems to work with that fix! I've updated 2.9.1 to support this. Only problem left is that Java 1.8 features are not taken in account in the bindings. So some methods are missing. |
I assume 2.9.1 hasn't been released yet? I just tried upgrading to 2.9.0 again since the latest VS for Mac uses OpenJDK 8. It appears the issue still persists even after the upgrade so I'm not convinced that's the only issue. If it makes any difference, the minimum SDK version I currently support is API 21, and raising it isn't likely an option just yet. I don't expect it is for most projects either.
|
Same issue... so disappointing. |
I'm also facing this issue once I upgraded to 2.9 looks like I'll wait for 15.10 until I upgrade to 2.9 |
Ping. Any way we could get an update on NuGet to fix this? I really don't understand why it's normal for packages to remain broken for months on end in the Xamarin world (this project is far from the only offender; Microsoft packages are even worse; I'm still multiple Xamarin.Forms versions behind because subsequent updates have bugs, won't compile, etc.). |
2.9.4 is committed and works in VS2019 preview2. We have to wait for that to release a stable new version. |
Awesome; thanks. Out of curiosity, is there an equivalent Mac preview release? |
Seems to be fixed on my side on Visual Studio 2019 Preview 2 (as i just encountered the bug). I had to add AndroidDesugar true, then everything worked on my side. |
How is this closed? Has no label/milestone since 9.4 isn't released |
@thomashagstrom because there is no need for a new release to make this work. You just need to use VS2019 |
Doesn't help mac users I suppose? Rider / VS Mac gives the same error. |
VS2019 for Mac might work but i have no idea, try to ask Microsoft to fix this. |
I upgraded to the just-released VS 2019 and v2.9.0. It compiles successfully after adding AndroidEnableDesugar but I get the following exception at runtime when setting PlayWhenReady to true: Java.Lang.AbstractMethodError: abstract method "void com.google.android.exoplayer2.Player$EventListener.onPlayerStateChanged(boolean, int)" This is discussed in #79 (comment) |
Do you have the same error if your replace:
to
instead ? |
|
No exception, but unfortunately the IPlayerEventListener methods no longer seem to be called. |
Are you on VS2019 RC or VS2019 Preview ? |
The official release version from today (16.0.0 Community). |
Ditto the above. Current dev tools info:
|
Steps to reproduce 📜
Upgrade via NuGet to 2.9.0
Rebuild Android project
Expected behavior 🤔
Successful build
Actual behavior 🐛
This causes a build failure in the Android project with several of these error lines in the output:
2>COMPILETODALVIK : PARSE error :
Note there are no error details displayed. If I return to the previous version I was using (2.8.5), it builds successfully.
Configuration 🔧
Version: 2.9.0
Platform:
The text was updated successfully, but these errors were encountered: