diff --git a/library/ssm_parameter_store.py b/library/ssm_parameter_store.py index 35fa766..b1c2fd1 100644 --- a/library/ssm_parameter_store.py +++ b/library/ssm_parameter_store.py @@ -131,7 +131,7 @@ def create_update_parameter(client, module): changed = False - reponse = {} + response = {} args = dict( Name=module.params.get('name'), @@ -147,21 +147,21 @@ def create_update_parameter(client, module): args.update(KeyId=module.params.get('key_id')) try: - reponse = client.put_parameter(**args) + response = client.put_parameter(**args) changed = True except ClientError as e: module.fail_json(msg=e.message, exception=traceback.format_exc(), **camel_dict_to_snake_dict(e.response)) - return changed, reponse + return changed, response def get_parameter(client, module): changed = False - reponse = {} + response = {} try: - reponse = client.get_parameters( + response = client.get_parameters( Names=[module.params.get('name')], WithDecryption=module.params.get('decryption') ) @@ -169,24 +169,24 @@ def get_parameter(client, module): module.fail_json(msg=e.message, exception=traceback.format_exc(), **camel_dict_to_snake_dict(e.response)) - return changed, reponse['Parameters'] + return changed, response['Parameters'] def delete_parameter(client, module): changed = False - reponse = {} + response = {} try: - get_reponse = client.get_parameters( + get_response = client.get_parameters( Names=[module.params.get('name')] ) except ClientError as e: module.fail_json(msg=e.message, exception=traceback.format_exc(), **camel_dict_to_snake_dict(e.response)) - if get_reponse['Parameters']: + if get_response['Parameters']: try: - reponse = client.delete_parameter( + response = client.delete_parameter( Name=module.params.get('name') ) changed = True @@ -194,7 +194,7 @@ def delete_parameter(client, module): module.fail_json(msg=e.message, exception=traceback.format_exc(), **camel_dict_to_snake_dict(e.response)) - return changed, reponse + return changed, response def main(): @@ -229,8 +229,8 @@ def main(): "present": create_update_parameter, "absent": delete_parameter, } - (changed, reponse) = invocations[state](client, module) - module.exit_json(changed=changed, response=reponse) + (changed, response) = invocations[state](client, module) + module.exit_json(changed=changed, response=response) if __name__ == '__main__': main() diff --git a/lookup/ssm.py b/lookup/ssm.py index 86a2761..c0a2f36 100644 --- a/lookup/ssm.py +++ b/lookup/ssm.py @@ -17,7 +17,8 @@ from __future__ import (absolute_import, division, print_function) __metaclass__ = type -from ansible.module_utils.ec2 import HAS_BOTO3 +import traceback +from ansible.module_utils.ec2 import HAS_BOTO3, camel_dict_to_snake_dict from ansible.errors import AnsibleError from ansible.plugins.lookup import LookupBase diff --git a/test/roles/test/tasks/main.yml b/test/roles/test/tasks/main.yml index ce6dc54..53b28c5 100644 --- a/test/roles/test/tasks/main.yml +++ b/test/roles/test/tasks/main.yml @@ -20,7 +20,7 @@ description: "This is your first key" region: us-east-1 string_type: "SecureString" - value: "World" + value: "World at us-east-1" - name: Create or update secure key/value pair with nominated kms key ssm_parameter_store: @@ -31,7 +31,7 @@ value: "World" - name: recommend to use with ssm lookup plugin - debug: msg="{{ lookup('ssm', 'hello') }}" + debug: msg="{{ lookup('ssm', 'Hello' ) }}" - name: lookup a key which is not exist debug: msg="{{ lookup('ssm', 'NoKey') }}"