Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: config reset at start #8

Closed
meyverick opened this issue Mar 3, 2025 · 2 comments
Closed

[Bug]: config reset at start #8

meyverick opened this issue Mar 3, 2025 · 2 comments
Labels
bug Something isn't working critical A breaking bug that needs immediate fixing.

Comments

@meyverick
Copy link

Describe the Bug

The config always reset to default at server start:

{
  "version": 1,
  "entities": {
    "minecraft:creeper": {
      "EXPLODE_BLOCKS": false
    },
    "minecraft:enderman": {
      "DESTROY_BLOCKS": false,
      "PLACE_BLOCKS": false
    },
    "minecraft:ghast": {
      "EXPLODE_BLOCKS": false
    },
    "minecraft:ravager": {
      "DESTROY_BLOCKS": false
    },
    "minecraft:wither": {
      "DESTROY_BLOCKS": false,
      "EXPLODE_BLOCKS": false
    }
  }
}

Steps to Reproduce

  1. Starts the server.
  2. Use commands to set the behavior: entityGriefing <entity> [<capability> [true|false]] and entityGriefingAll <capability> <true|false>
  3. Shutdown the server. The config file is saved.
  4. Starts the server again: the config has reset.

Expected Behavior

Save this config:

{
  "version": 1,
  "entities": {
    "minecraft:blaze": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:bogged": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:breeze": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:camel": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:cow": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:creaking": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:creeper": {
      "EXPLODE_BLOCKS": false,
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:donkey": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:drowned": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:elder_guardian": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:ender_dragon": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:enderman": {
      "DESTROY_BLOCKS": false,
      "PLACE_BLOCKS": false,
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:evoker": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:ghast": {
      "EXPLODE_BLOCKS": false,
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:giant": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:goat": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:guardian": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:hoglin": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:horse": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:husk": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:illusioner": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:iron_golem": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:llama": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:mooshroom": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:mule": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:panda": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:pig": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:piglin": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:piglin_brute": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:pillager": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:player": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:polar_bear": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:ravager": {
      "DESTROY_BLOCKS": false,
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:sheep": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:shulker": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:skeleton": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:sniffer": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:snow_golem": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:spider": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:stray": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:strider": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:turtle": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:villager": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:vindicator": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:warden": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:witch": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:wither": {
      "DESTROY_BLOCKS": false,
      "EXPLODE_BLOCKS": false,
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:wither_skeleton": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:zoglin": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:zombie": {
      "BREAK_DOORS": false,
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:zombie_horse": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:zombie_villager": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    },
    "minecraft:zombified_piglin": {
      "TRAMPLE_CROPS": false,
      "TRAMPLE_FARMLAND": false
    }
  }
}

Screenshots

No response

Fabric Version

Minecraft 1.21.4 / Fabric 0.16.10

Mod Version

1.0.6

Log Output

No error.

Additional Context

No response

@BVengo
Copy link
Owner

BVengo commented Mar 6, 2025

Update from a quick test (I won't have time to fix it right away).

Ignored invalid capability TRAMPLE_CROPS for entity <...>
Ignored invalid capability TRAMPLE_FARMLAND for entity <...>
Ignored invalid capability BREAK_DOORS for entity minecraft:zombie

So the configs are being partially read, but what looks to be the calculated fields are being ignored (TBC).

Thanks again for flagging such a critical bug.

@BVengo BVengo added bug Something isn't working critical A breaking bug that needs immediate fixing. labels Mar 6, 2025
@meyverick
Copy link
Author

Thank you for your investigation 🙂

@BVengo BVengo closed this as completed in 3978fda Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical A breaking bug that needs immediate fixing.
Projects
None yet
Development

No branches or pull requests

2 participants