Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenario filtering empty parameter bug #1217

Closed
michal-pekacki opened this issue Jul 1, 2022 · 0 comments · Fixed by #1218
Closed

Scenario filtering empty parameter bug #1217

michal-pekacki opened this issue Jul 1, 2022 · 0 comments · Fixed by #1218
Assignees
@michal-pekacki
Labels
type:bug Error or unexpected behaviour
Milestone
BHoM 5.3 β MVP

Comments

@michal-pekacki
Copy link
Contributor

Description:

Filtering doesn't work correctly for empty parameter values.

Steps to reproduce:

  1. Open Insulation Tool setting window
  2. Set filtering in scenario for any parameter as Not Equal or Not Contains (may be Comments)
  3. Run apply method
  4. All elements with the empty parameter value will be out of the scenario what is wrong

Expected behaviour:

Elements with empty values to pass scenario filtering.

Test file(s):
@michal-pekacki michal-pekacki added the type:bug Error or unexpected behaviour label Jul 1, 2022
@michal-pekacki michal-pekacki added this to the BHoM 5.3 β MVP milestone Jul 1, 2022
@michal-pekacki michal-pekacki self-assigned this Jul 1, 2022
@michal-pekacki michal-pekacki mentioned this issue Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michal-pekacki michal-pekacki

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
BHoM 5.3 β MVP
Development

Successfully merging a pull request may close this issue.

Scenario filtering empty parameter fix BHoM/Revit_Toolkit
1 participant
@michal-pekacki