Stop App Lock on Error #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHenriksen
added
status:do-not-merge
MartinHenriksen
removed
status:WIP
|
@MartinHenriksen Any Progress on this? @staintono @AjohnnashA are you able to test this? |
staintono
reviewed
Apr 14, 2020
|
/azp run RFEM_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MartinHenriksen
added
severity:medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #7
Exceptions raised during execution caused RFEM app to hang/lock up.
Test files
no test file. To test an intentional exception must be raised.
e.g..: on line 56 in Read Bar class, change increment from '+1' to '+10' to force reading non-existing Bar element:
lineIdNum = modelData.GetLineCount() + 10;expected behaviour would be for operation to fail while RFEM app remains responsive.