Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LadybugTools_Toolkit: Review or remove FromHoneyBeeSurface #48

Closed
jamesramsden-bh opened this issue Mar 18, 2022 · 1 comment
Closed

LadybugTools_Toolkit: Review or remove FromHoneyBeeSurface #48

jamesramsden-bh opened this issue Mar 18, 2022 · 1 comment
Labels
type:compliance Non-conforming to code guidelines

Comments

@jamesramsden-bh
Copy link
Contributor

Broken rules:

FromHoneyBeeSurface currently takes in a honeybeeSrf type, which appears to no longer be a valid type in newer versions of Honeybee.

Suggestions to restore compliance:

Update this method for a current surface type, or remove the method altogether.
@jamesramsden-bh jamesramsden-bh added the type:compliance Non-conforming to code guidelines label Mar 18, 2022
@Tom-Kingstone
Copy link
Contributor

The method was removed as part of the 7.0 beta in #124, but was missed for closure.

@Tom-Kingstone Tom-Kingstone mentioned this issue Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesramsden-bh @Tom-Kingstone